Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSP/qomu: fix qomu_hardwaresetup declaration #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trabucayre
Copy link

There is a inconsistency between function declaration (BSP/inc/qomu_hardwaresetup.h) and implementation (BSP/src/qomu_hardwaresetup.c). Former has an upper case 'S' and latter has an lower case 's'.

Due to this case issue a warning appear at compile time:

xxx/src/main.c: In function 'main':
xxx/src/main.c:22:2: warning: implicit declaration of function 'qomu_hardwaresetup'; did you mean 'qomu_hardwareSetup'? [-Wimplicit-function-declaration]
   22 |  qomu_hardwaresetup();
      |  ^~~~~~~~~~~~~~~~~~
      |  qomu_hardwareSetup

According to all examples name must be qomu_hardwaresetup.

Side question: quickfeather setup is called qf_hardwareSetup (uppercase 'S') why not using same naming convention for Qomu?

@trabucayre
Copy link
Author

ping ?
checks failure seems not related to this PR.

@coolbreeze413
Copy link
Collaborator

@trabucayre Yes you are right, we will work on fixing this as part of adding new applications to qomu shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants