Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#137) optimize family notifications for world.entity and entity.configure #138

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

Quillraven
Copy link
Owner

@Quillraven Quillraven commented Apr 2, 2024

PR for #137: FamilyHook notifications are only called once for an entity within nested calls like:

// 1
world.entity {
  // it.configure will not trigger family notifications for that entity anymore. They are triggered at the end of world.entity
  it.configure {

  }
}

// 2
entity.configure{
  // it.configure will not trigger family notifications for that entity anymore. They are triggered at the end of the first entity.configure call
  it.configure{

  }
}

@Quillraven Quillraven added the enhancement New feature or request label Apr 2, 2024
@Quillraven Quillraven added this to the 2.7 milestone Apr 2, 2024
@Quillraven Quillraven merged commit 3154335 into master Apr 2, 2024
4 checks passed
@Quillraven Quillraven deleted the #137_optimize-family-notifications branch April 2, 2024 20:07
@Quillraven Quillraven mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant