Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite readme #465

Merged
merged 13 commits into from
Aug 12, 2023
Merged

rewrite readme #465

merged 13 commits into from
Aug 12, 2023

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Jul 17, 2023

TODO:

  • make a guide on using enigma

rewrites the QM readme so it's not
a. incorrect
or
b. a weird homunculus of yarn's readme + the word "quilt" added on top

@ix0rai ix0rai added documentation improvements or additions to documentation wip this is a work in progress reviews needed please review this PR s: small PRs with less than 200 lines labels Jul 17, 2023
README.md Outdated Show resolved Hide resolved
ix0rai and others added 3 commits July 16, 2023 22:05
Co-authored-by: Will <supersaiyansubtlety@gmail.com>
@ix0rai ix0rai marked this pull request as ready for review July 25, 2023 22:17
Copy link
Contributor

@supersaiyansubtlety supersaiyansubtlety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing: I hadn't heard the term "docker" used this way before. I'd heard of "docking" views to the side, though, so it was reasonably easy to figure out from context.

It might be worth having a short explanation of what docker means, but I'm not sure how widely known this term is so I can't really say for sure.

GUIDE.md Outdated Show resolved Hide resolved
GUIDE.md Outdated Show resolved Hide resolved
GUIDE.md Outdated Show resolved Hide resolved
GUIDE.md Outdated Show resolved Hide resolved
GUIDE.md Outdated Show resolved Hide resolved
GUIDE.md Outdated Show resolved Hide resolved
GUIDE.md Outdated Show resolved Hide resolved
GUIDE.md Outdated Show resolved Hide resolved
GUIDE.md Outdated Show resolved Hide resolved
Co-authored-by: Will <supersaiyansubtlety@gmail.com>
GUIDE.md Show resolved Hide resolved
GUIDE.md Outdated Show resolved Hide resolved
GUIDE.md Show resolved Hide resolved
GUIDE.md Show resolved Hide resolved
Co-authored-by: ByMartrixx <47987888+ByMartrixx@users.noreply.github.com>
GUIDE.md Outdated Show resolved Hide resolved
@ix0rai
Copy link
Member Author

ix0rai commented Jul 27, 2023

@supersaiyansubtlety you're too fast I was already fixing that :p

@ix0rai ix0rai removed the wip this is a work in progress label Jul 28, 2023
@ix0rai ix0rai requested a review from OroArmor July 28, 2023 17:32
Copy link
Contributor

@EnnuiL EnnuiL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, before I review this tomorrow, I'm wondering: shouldn't we get rid of those line breaks in favor of text wrapping? I feel like text wrapping on IDE's side might end being better for like, writing and expanding these docs

Copy link
Contributor

@EnnuiL EnnuiL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i can tackle this small bit today

GUIDE.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with Ennui's changes

@ix0rai
Copy link
Member Author

ix0rai commented Aug 6, 2023

I Hate Capital Letters

Co-authored-by: Ennui Langeweile <85590273+EnnuiL@users.noreply.github.com>
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Aug 6, 2023
@github-actions github-actions bot changed the base branch from 1.20.1 to 23w31a August 6, 2023 01:16
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

🚀 Target branch has been updated to 23w31a

@github-actions github-actions bot added v: snapshot targets a snapshot version of minecraft and removed update-base used to notify github actions that the base branch should be updated labels Aug 6, 2023
@ix0rai ix0rai requested a review from EnnuiL August 6, 2023 03:04
@ix0rai ix0rai added update-base used to notify github actions that the base branch should be updated and removed reviews needed please review this PR labels Aug 7, 2023
@github-actions github-actions bot changed the base branch from 23w31a to 23w32a August 10, 2023 02:21
@github-actions
Copy link
Contributor

🚀 Target branch has been updated to 23w32a

@ix0rai ix0rai removed the update-base used to notify github actions that the base branch should be updated label Aug 10, 2023
@ix0rai ix0rai added the final-comment-period is approved and will soon be merged if no issues are raised label Aug 10, 2023
@EnnuiL EnnuiL merged commit b56d116 into QuiltMC:23w32a Aug 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation improvements or additions to documentation final-comment-period is approved and will soon be merged if no issues are raised s: small PRs with less than 200 lines v: snapshot targets a snapshot version of minecraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants