Support for 1.20.3/4 #356
Merged
Support for 1.20.3/4 #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good from a cursory glance. Once I have time to fix 1.20.2, I'll merge that into this and then make a new 1.20.3 branch for 1.20.3/4 and then merge this |
OroArmor
requested changes
Feb 8, 2024
library/data/advancement/src/main/resources/quilt_advancement.mixins.json
Outdated
Show resolved
Hide resolved
library/data/recipe/src/main/resources/quilt_recipe.accesswidener
Outdated
Show resolved
Hide resolved
...rldgen/dimension/src/testmod/java/org/quiltmc/qsl/worldgen/dimension/QuiltDimensionTest.java
Show resolved
Hide resolved
Co-Authored-By: Eli Orona <eliorona@live.com>
ghost
mentioned this pull request
OroArmor
approved these changes
Mar 15, 2024
|
Why is the target branch named 1.20.3 and not 1.20.4? 1.20.3 is just 1.20.4 with a missing markDirty |
|
20.3 and 20.4 are compatible. if we updated on time, we would stay on the 20.3 branch and add support from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks:
modsblockInformation: builds succeed, but gradle will still spit out errors about the javadocs as well as about not finding some of minecraft's classes. I don't know if these "errors" were present before, but the mod works fine.