-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport fixed Recipe Remainder API to 1.20.1 #373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Didn't see any issues in the port. Was it fully tested?
I ran through all tests in the testmod, and yeah, I can confirm it all works (especially after merging your fixes in, because without those, it crashed!); The only test I kinda forgot about is the brewing stand one though, but I could give a try now |
Update: I'll have to double-check the brewing stand stuff at home, the missing texture hecker got eaten by the brewing stand with no remainders left, which I believe is not supposed to happen with non-dragon's breath stuff (oh also I might update CI workflows too) |
b479715
to
24e598f
Compare
This also updates dependencies in preparation for another API-adding PR