Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fixed Recipe Remainder API to 1.20.1 #373

Merged
merged 7 commits into from
Jul 6, 2024

Conversation

EnnuiL
Copy link
Contributor

@EnnuiL EnnuiL commented Jun 3, 2024

This also updates dependencies in preparation for another API-adding PR

Copy link
Member

@OroArmor OroArmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Didn't see any issues in the port. Was it fully tested?

@EnnuiL
Copy link
Contributor Author

EnnuiL commented Jun 6, 2024

Looks good. Didn't see any issues in the port. Was it fully tested?

I ran through all tests in the testmod, and yeah, I can confirm it all works (especially after merging your fixes in, because without those, it crashed!); The only test I kinda forgot about is the brewing stand one though, but I could give a try now

@EnnuiL
Copy link
Contributor Author

EnnuiL commented Jun 6, 2024

Looks good. Didn't see any issues in the port. Was it fully tested?

I ran through all tests in the testmod, and yeah, I can confirm it all works (especially after merging your fixes in, because without those, it crashed!); The only test I kinda forgot about is the brewing stand one though, but I could give a try now

Update: I'll have to double-check the brewing stand stuff at home, the missing texture hecker got eaten by the brewing stand with no remainders left, which I believe is not supposed to happen with non-dragon's breath stuff

(oh also I might update CI workflows too)

@EnnuiL EnnuiL force-pushed the backport/recipe_remainder branch from b479715 to 24e598f Compare June 6, 2024 21:52
@ix0rai ix0rai added library: item Related to the item library. ready-to-merge The pull request is ready to be merged. s: tested This pull request has been tested and confirmed as working. and removed ready-to-merge The pull request is ready to be merged. labels Jun 25, 2024
@OroArmor OroArmor merged commit 3839acf into QuiltMC:1.20 Jul 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library: item Related to the item library. s: tested This pull request has been tested and confirmed as working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants