Astro 5 #262
Merged
Astro 5 #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Astro.glob() is deprecated in Astro 5
It doesn’t seem to support Astro 5
That was what was causing the issue all along.
Pyrofab
reviewed
Dec 29, 2024
|
|
||
| const allPosts = (await Astro.glob("/src/pages/**/blog/*.md")).filter((p) => | ||
| const allPosts = (Object.values(import.meta.glob("/src/pages/**/blog/*.md", {eager: true})) as [MarkdownInstance<BlogFrontMatter>]).filter((p) => |
There was a problem hiding this comment.
Is eager: true relevant for markdown files ?
Pyrofab
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Astro from Astro 4 to Astro 5.
Changes:
getCompiledContent()function of Markdown files are now asynchronous.Astro.glob()are replaced with Vite'simport.meta.glob()asAstro.glob()is deprecated. Calls are also now properly typed.There are no user-facing changes, but the upgrade should pave the way for moving to more modern Astro features, such as Content Loaders. I have noticed some encoding issues when using the dev server, but these don't appear in the production site, so I think it's fine.
See preview on Cloudflare Pages: https://preview-262.quiltmc-org.pages.dev