FIX: Authentication issue with stage workaround #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching from ?stage=Stage which, would obviously be ideal as anyone would like to know how it scores before it's published... we're presented with an authentication issue that is only logged in users are able to see ?stage=Stage whereas file_get_contents() doesn't allow that.
Moving forward, maybe we could tokenize an authenticated request using HTTPMiddleware and pass it along with the file_get_contents call.
Currently, with this; the "new page" bug is fixed; but will still display "Login" in the preview until the page is published.