Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render html using render() rather than file_get_contents etc #35

Merged

Conversation

gopalsareen
Copy link

@gopalsareen gopalsareen commented Nov 2, 2018

  1. Render Html using render() rather than file_get_contents
  2. Config Yaml name added for the purpose of After/Before priority.
  3. Grid Field modified: field names added so that fields can be moved.

@codecov-io
Copy link

Codecov Report

Merging #35 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #35      +/-   ##
===========================================
- Coverage     33.48%   33.4%   -0.08%     
  Complexity      176     176              
===========================================
  Files            16      16              
  Lines           451     452       +1     
===========================================
  Hits            151     151              
- Misses          300     301       +1
Impacted Files Coverage Δ Complexity Δ
src/Extensions/PageSeoExtension.php 50% <0%> (ø) 8 <0> (ø) ⬇️
src/Extensions/PageHealthExtension.php 0% <0%> (ø) 8 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 818d2c2...bbcc780. Read the comment docs.

@gopalsareen gopalsareen changed the title Render html using render() rather than file_get_contents, and config yml name Render html using render() rather than file_get_contents etc Nov 2, 2018
@wilr
Copy link
Contributor

wilr commented Mar 13, 2019

ping @zanderwar?

@zanderwar zanderwar self-requested a review March 13, 2019 06:34
@zanderwar
Copy link
Contributor

Thank you for this, apologies for the delay

@zanderwar zanderwar merged commit 9b5c2f0 into Quinn-Interactive:master Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants