Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Onbording/Homepage] AADev, i don't have a feature flag on onboarding and new homepage features #1490

Closed
mamadoudicko opened this issue Oct 25, 2023 · 2 comments
Assignees
Labels
area: frontend Related to frontend functionality or under the /frontend directory Stale

Comments

@mamadoudicko
Copy link
Contributor

mamadoudicko commented Oct 25, 2023

Remove feature flags on:

  • onboarding
  • homepage
@mamadoudicko mamadoudicko converted this from a draft issue Oct 25, 2023
@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label Oct 25, 2023
@dosubot
Copy link

dosubot bot commented Oct 25, 2023

🤖

Hello AADev,

The feature flag for onboarding is already implemented in the Quivr codebase. It's being used to determine whether the onboarding steps should be displayed or not. The feature flag is implemented using the useFeatureIsOn hook from the @growthbook/growthbook-react library. Here is the relevant code:

const shouldStepBeDisplayed = useFeatureIsOn("onboarding");

if (!shouldStepBeDisplayed) {
  return <Fragment />;
}

In this code, useFeatureIsOn("onboarding") checks if the "onboarding" feature is turned on. If it's not, the component returns an empty fragment, effectively not rendering the onboarding steps. If the feature is turned on, the onboarding steps are rendered as per the rest of the component's code.

You can find this in the Onboarding.tsx file.

For implementing a similar feature flag for new homepage features, you can follow a similar approach. You would use the useFeatureIsOn hook with a different feature name, say "newHomepage", and conditionally render the new homepage features based on the value returned by the hook.

The current version of the @growthbook/growthbook-react library being used in the Quivr codebase is 0.17.0, as specified in the package.json file.

I hope this helps! If you have any other questions or need further clarification, feel free to ask.

Best,
Dosu

Sources


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@matthieujacq matthieujacq moved this from Todo to In Progress in Quivr's Roadmap Oct 26, 2023
mamadoudicko pushed a commit that referenced this issue Oct 26, 2023
@matthieujacq matthieujacq moved this from In Progress to To Be Validated in Quivr's Roadmap Oct 26, 2023
@mamadoudicko mamadoudicko moved this from To Be Validated to Done in Quivr's Roadmap Oct 30, 2023
Copy link
Contributor

Thanks for your contributions, we'll be closing this issue as it has gone stale. Feel free to reopen if you'd like to continue the discussion.

@github-actions github-actions bot added the Stale label Nov 24, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory Stale
Projects
None yet
Development

No branches or pull requests

2 participants