Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brain as API] 6.C AAU, in brain management settings tab, i can see but not update the API definition in brains management #1627

Closed
mamadoudicko opened this issue Nov 14, 2023 · 3 comments
Assignees
Labels
area: backend Related to backend functionality or under the /backend directory area: frontend Related to frontend functionality or under the /frontend directory Stale

Comments

@mamadoudicko
Copy link
Contributor

No description provided.

@mamadoudicko mamadoudicko converted this from a draft issue Nov 14, 2023
@mamadoudicko mamadoudicko self-assigned this Nov 14, 2023
Copy link

dosubot bot commented Nov 14, 2023

🤖

Hello @mamadoudicko,

Great to see you back here! I remember our interaction from the last issue you reported, and it's nice to have you contributing to Quivr again.

I'm currently looking into the issue you've reported about the API definition in the brains management. I'll provide a detailed response as soon as possible. Thank you for your patience!

@mamadoudicko mamadoudicko changed the title [Brain as API] 6.C AAU, i can see but not update the API definition in brains management [Brain as API] 6.C AAU, in brain management settings tab, i can see but not update the API definition in brains management Nov 14, 2023
@dosubot dosubot bot added area: backend Related to backend functionality or under the /backend directory area: frontend Related to frontend functionality or under the /frontend directory labels Nov 14, 2023
Copy link

dosubot bot commented Nov 14, 2023

🤖

Based on the current structure of the Quivr codebase, the functionality to update the API definition is not exposed in the set of methods in the brains.py file of the backend/models/databases/supabase repository. The available methods are for creating, deleting, getting, and updating brains and brain users, but there is no method for updating the API definition itself.

The update_brain_by_id method is available, but it only allows updating of certain properties of a brain as defined in the BrainUpdatableProperties class, which does not include the API definition.

To add the ability to update the API definition, a new method would need to be added to the brains.py file, such as update_api_definition. However, as a maintainer, I don't have the ability to create pull requests or issues.

You can refer to the following sources for more information:

As for the structure of the API definition in the Quivr codebase and the specific reason why the functionality to update the API definition is not included in the current version of Quivr, I wasn't able to find an answer within the repository. It's possible that this information may be available elsewhere or I could have missed it. If you have more specific information or context, it would be helpful in providing a more accurate response.

Sources


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@mamadoudicko mamadoudicko moved this from Todo to In Progress in Quivr's Roadmap Nov 15, 2023
gozineb pushed a commit that referenced this issue Nov 16, 2023
@mamadoudicko mamadoudicko moved this from In Progress to To Be Validated in Quivr's Roadmap Nov 16, 2023
@Chloeroumengas Chloeroumengas moved this from To Be Validated to Done in Quivr's Roadmap Dec 4, 2023
Copy link
Contributor

Thanks for your contributions, we'll be closing this issue as it has gone stale. Feel free to reopen if you'd like to continue the discussion.

@github-actions github-actions bot added the Stale label Dec 14, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2023
coolCatalyst added a commit to coolCatalyst/quivr that referenced this issue Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to backend functionality or under the /backend directory area: frontend Related to frontend functionality or under the /frontend directory Stale
Projects
None yet
Development

No branches or pull requests

1 participant