Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add prompt trigger through # #1023

Merged
merged 12 commits into from
Aug 29, 2023
Merged

feat: add prompt trigger through # #1023

merged 12 commits into from
Aug 29, 2023

Conversation

mamadoudicko
Copy link
Contributor

Description

@mamadoudicko mamadoudicko temporarily deployed to preview August 22, 2023 17:23 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Aug 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 7:24am
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 7:24am

@mamadoudicko mamadoudicko mentioned this pull request Aug 22, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023 •
edited
Loading

Risk Level 3 - /home/runner/work/quivr/quivr/frontend/lib/context/BrainProvider/hooks/useBrainProvider.ts

The changes in this file introduce new state variables and functions related to publicPrompts and currentPromptId. These additions seem to be well-structured and do not appear to introduce any potential bugs. However, the use of void 0 in the createBrainHandler function could be replaced with a more explicit return undefined for readability. Additionally, the fetchPublicPrompts function could benefit from error handling.

Risk Level 3 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/components/ChatInput/components/ChatBar/components/MentionInput/MentionInput.tsx

The developer has made significant changes to the MentionInput component. They have added a new visibility style based on the open state. This could potentially cause issues with the visibility of the component. It's recommended to test this thoroughly to ensure it behaves as expected.

Risk Level 3 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/components/ChatInput/components/ChatBar/components/MentionInput/hooks/helpers/MentionState.ts

The developer has made significant changes to the useMentionState hook. They have added new state variables and updated the useEffect hooks. It's important to ensure that the dependencies of the useEffect hooks are correct to avoid unnecessary re-renders or stale state.

📝🔍🐛

Powered by Code Review GPT

gozineb
gozineb reviewed Aug 22, 2023
View reviewed changes
frontend/lib/context/BrainProvider/hooks/useBrainProvider.ts
@@ -118,5 +131,10 @@ export const useBrainProvider = () => {
isFetchingBrains,
defaultBrainId,
fetchDefaultBrain,
fetchPublicPrompts,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ca commence a devenir un peu fat pour un brain provider

gozineb
gozineb previously approved these changes Aug 23, 2023
View reviewed changes
@mamadoudicko mamadoudicko temporarily deployed to preview August 24, 2023 08:33 — with GitHub Actions Inactive
gozineb
gozineb reviewed Aug 24, 2023
View reviewed changes
frontend/.eslintrc.js Outdated
@@ -13,6 +13,7 @@ module.exports = {
"import/no-unresolved": 0,
"import/prefer-default-export": 0,
"import/no-duplicates": "error",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this, francoisH is gonna KO this

@mamadoudicko mamadoudicko temporarily deployed to preview August 25, 2023 07:41 — with GitHub Actions Inactive
@mamadoudicko mamadoudicko temporarily deployed to preview August 25, 2023 07:54 — with GitHub Actions Inactive
@mamadoudicko mamadoudicko temporarily deployed to preview August 28, 2023 16:29 — with GitHub Actions Inactive
@mamadoudicko mamadoudicko temporarily deployed to preview August 28, 2023 17:46 — with GitHub Actions Inactive
gozineb
gozineb previously approved these changes Aug 29, 2023
View reviewed changes
@mamadoudicko mamadoudicko temporarily deployed to preview August 29, 2023 07:23 — with GitHub Actions Inactive
@gozineb gozineb merged commit 072d97a into main Aug 29, 2023
7 checks passed
@StanGirard StanGirard mentioned this pull request Aug 29, 2023
Merged
Colin-coder pushed a commit to Colin-coder/quivr that referenced this pull request Aug 30, 2023
@mamadoudicko @Colin-coder
feat: add prompt trigger through # (QuivrHQ#1023)
2b4dfde 
* feat: add prompt trigger to mention input

* feat: update chat shortcuts

* test: update BrainProviderMock

* feat: improve ux

* feat: update message header position

* feat: improve mention input dx

* fix(MentionInput): fix minor bugs

* feat: refactor <ShareBrain/>

* feat: add brain sharing button

* fix: make popover buttons click working

* feat: update backspace handle logic

* feat: update add new brain button ui
StanGirard pushed a commit that referenced this pull request Sep 12, 2023
@mamadoudicko
feat: add prompt trigger through # (#1023)
0d10033 
* feat: add prompt trigger to mention input

* feat: update chat shortcuts

* test: update BrainProviderMock

* feat: improve ux

* feat: update message header position

* feat: improve mention input dx

* fix(MentionInput): fix minor bugs

* feat: refactor <ShareBrain/>

* feat: add brain sharing button

* fix: make popover buttons click working

* feat: update backspace handle logic

* feat: update add new brain button ui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gozineb gozineb gozineb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamadoudicko @gozineb