feat: validate api key before saving

[mamadoudicko]

• Validate api key before saving

Screen.Recording.2023-08-29.at.17.42.40.mov

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 30, 2023 7:13am
quivrapp	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 30, 2023 7:13am

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/brains-management/[brainId]/components/BrainManagementTabs/components/SettingsTab/hooks/useSettingsTab.ts

The code seems to be well written and follows good practices. However, there are a few areas that could be improved for better readability and maintainability:

1. Avoid magic numbers: The setTimeout function has a delay of 50 milliseconds. It would be better to define this value as a constant at the top of the file, giving it a descriptive name. This makes the code easier to understand and modify.

const MODEL_SET_DELAY = 50;
// ...
setTimeout(() => {
  if (brain.model !== undefined) {
    setValue(\"model\", brain.model);
  }
}, MODEL_SET_DELAY);

2. Error handling: There are several places where async functions are called without try-catch blocks. This could lead to unhandled promise rejections if these functions throw errors. It's recommended to always handle errors from async functions.

try {
  const brain = await getBrain(brainId);
  // ...
} catch (error) {
  // Handle error
}

3. Use optional chaining: There are several places where properties are accessed on objects that could potentially be undefined. This could lead to runtime errors. It's recommended to use optional chaining (?.) to safely access these properties.

const isDefaultBrain = defaultBrainId === brainId;
// becomes
const isDefaultBrain = defaultBrainId?. === brainId;

---

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/user/components/ApiKeyConfig/hooks/useApiKeyConfig.ts

The code is generally well written, but there are a few areas that could be improved:

1. Avoid console logging: There are several instances where errors are logged to the console. This is not a good practice for production code as it can expose sensitive information. It's recommended to use a logging service that can capture and manage logs securely.

try {
  const createdApiKey = await createApiKey();
  setApiKey(createdApiKey);
} catch (error) {
  // Replace console.error with a secure logging service
}

2. Error handling: Similar to the previous file, there are several places where async functions are called without try-catch blocks. This could lead to unhandled promise rejections if these functions throw errors. It's recommended to always handle errors from async functions.

try {
  await updateUserIdentity({
    openai_api_key: null,
  });
  // ...
} catch (error) {
  // Handle error
}

---

🔢🔍🔐

---

Powered by Code Review GPT