Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow user to chat while feed process is pending #1120

Merged
merged 3 commits into from
Sep 7, 2023
Merged

feat: allow user to chat while feed process is pending #1120

merged 3 commits into from
Sep 7, 2023

Conversation

mamadoudicko
Copy link
Contributor

@mamadoudicko mamadoudicko commented Sep 6, 2023 •
edited
Loading

Screen.Recording.2023-09-06.at.15.06.03.mov

@vercel
Copy link

vercel bot commented Sep 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 8:13am
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 8:13am

@mamadoudicko mamadoudicko temporarily deployed to preview September 6, 2023 13:00 — with GitHub Actions Inactive
@mamadoudicko mamadoudicko mentioned this pull request Sep 6, 2023
Closed
@mamadoudicko mamadoudicko temporarily deployed to preview September 6, 2023 13:03 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023 •
edited
Loading

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/components/ChatInput/index.tsx

The changes in this file are adding a new property hasContentToFeedBrain to the ChatInput component and using it to disable the Button component. This is a low to medium risk change as it is modifying the behavior of the Button component based on the new property. Make sure that the new property is always correctly set to avoid unexpected behavior.

Risk Level 3 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/hooks/useKnowledgeUploader.ts

The changes in this file are more significant and involve modifying the feedBrain function to use Promise.all for handling multiple promises. This is a medium risk change as it modifies the existing logic and could potentially lead to unhandled promise rejections if not properly implemented. Make sure to handle any errors that might occur during the execution of the promises.

For example:

try {
  await Promise.all([...uploadPromises, ...crawlPromises]);
} catch (e) {
  console.error(e);
}

📁🔧⚠️

Powered by Code Review GPT

@mamadoudicko mamadoudicko temporarily deployed to preview September 7, 2023 08:11 — with GitHub Actions Inactive
@gozineb gozineb merged commit a14c033 into main Sep 7, 2023
7 checks passed
@StanGirard StanGirard mentioned this pull request Sep 7, 2023
Merged
StanGirard pushed a commit that referenced this pull request Sep 12, 2023
@mamadoudicko
feat: allow user to chat while feed process is pending (#1120)
49e6f5a 
* feat: remove 'ux-upload' feature flag

* feat: publish a message at the end of feed process

* feat: hide feed card during feed process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gozineb gozineb gozineb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamadoudicko @gozineb