Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add polling for pending notifications #1152

Merged
merged 3 commits into from
Sep 12, 2023
Merged

feat: add polling for pending notifications #1152

merged 3 commits into from
Sep 12, 2023

Conversation

mamadoudicko
Copy link
Contributor

@mamadoudicko mamadoudicko commented Sep 12, 2023

  • Add polling logic on pending notifications on chat page
Screen.Recording.2023-09-12.at.16.46.23.mov

@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2023 3:49pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2023 3:49pm

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/ActionsBar.tsx

The changes in this file involve the addition of a new state variable setHasPendingRequests and its usage in the useKnowledgeUploader hook. This seems to be a standard operation in React and should not pose any risk. However, it's important to ensure that the state is managed correctly to avoid potential bugs.


Risk Level 3 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/hooks/useSelectedChatPage.ts

The changes in this file involve the addition of a new query for fetching notifications and its usage in a useEffect hook. This could potentially introduce bugs if not handled correctly. It's important to ensure that error handling is done properly and that the query is used in the correct places.


Risk Level 3 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ActionsBar/hooks/useKnowledgeUploader.ts

The changes in this file involve the addition of a new function fetchNotifications and its usage in various places. This could potentially introduce bugs if not handled correctly. It's important to ensure that error handling is done properly and that the function is called in the correct places.


📁🐛⚠️


Powered by Code Review GPT

@gozineb gozineb merged commit 7cc90ef into main Sep 12, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants