Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chatPage): update ui add new feed component #1275

Merged
merged 6 commits into from
Sep 28, 2023

Conversation

mamadoudicko
Copy link
Contributor

@mamadoudicko mamadoudicko commented Sep 27, 2023

https://www.loom.com/share/8729eacdf3d24d8ea6b990a540a61c25?sid=647463b7-7168-4686-af57-87603e4d7224

  • Implemented drag and drop on page level for file upload
  • Introduced sliding effect for paperclip interaction
  • Maintained always-visible grayed-out conversation
  • Cleared brain selection if none was previously selected
  • Arranged documents with 4 per row in a responsive way
  • Enabled dynamic modal expansion with document additions
  • Turned "Send to my brain" button purple upon brain selection and document upload
  • Removed save buttons for public brains in subscriber view

#1220

@mamadoudicko mamadoudicko temporarily deployed to preview September 27, 2023 15:51 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 4:01pm
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 4:01pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 4:01pm

@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Risk Level 3 - /home/runner/work/quivr/quivr/frontend/lib/components/KnowledgeToFeedInput/hooks/useKnowledgeToFeedInput.ts.ts

The code seems to be well written and follows good practices. However, there is a potential risk of currentBrainId being null which might cause issues in the feedBrain function. Consider adding a check for currentBrainId before executing the feedBrain function.

const feedBrain = async (): Promise<void> => {
  if (!currentBrainId) {
    publish({
      variant: \"danger\",
      text: t(\"selectBrainFirst\"),
    });
    return;
  }
  ...
};

Risk Level 3 - /home/runner/work/quivr/quivr/frontend/app/chat/layout.tsx

The code seems to be removing the ChatsProvider and ChatProvider and replacing them with KnowledgeProvider. This might cause issues if there are components that rely on the context provided by ChatsProvider and ChatProvider. Ensure that the KnowledgeProvider provides all the necessary context that was previously provided by the removed providers.


Risk Level 4 - /home/runner/work/quivr/quivr/frontend/lib/hooks/useDropzone.ts

The changes introduce a new custom hook useCustomDropzone which wraps the useDropzone hook from react-dropzone. The hook seems to be correctly implemented, but it's important to ensure that it is properly tested. Also, the maxSize property is set to 100000000 which is actually 100 MB, not 1 MB as the comment suggests. This discrepancy should be clarified.


🔍🐛💡


Powered by Code Review GPT

@gozineb gozineb merged commit 2226eef into main Sep 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants