Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ↕️ Maximise chat window #1301

Merged
merged 7 commits into from
Oct 3, 2023
Merged

feat: ↕️ Maximise chat window #1301

merged 7 commits into from
Oct 3, 2023

Conversation

matthieujacq
Copy link
Contributor

@matthieujacq matthieujacq commented Oct 2, 2023 •
edited
Loading

@matthieujacq matthieujacq self-assigned this Oct 2, 2023
@matthieujacq matthieujacq temporarily deployed to preview October 2, 2023 15:27 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Oct 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 10:14am
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 10:14am
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 10:14am

@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label Oct 2, 2023
@matthieujacq matthieujacq changed the title feat: Maximise chat window feat: ↕️ Maximise chat window Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023 •
edited
Loading

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/lib/components/NavBar/index.tsx

The changes in this file involve adding some conditional logic to determine whether to render the NavBar component. While this is a common pattern in React, it could potentially introduce bugs if the conditions are not correct. It would be a good idea to manually test these changes to ensure they work as expected. Also, the removal of the Header, Logo, NavItems, and MobileMenu components could potentially introduce bugs or layout issues, so these changes should be tested thoroughly.

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/page.tsx

The changes in this file involve adding some div elements and CSS classes. While these changes are generally safe, they could potentially introduce visual bugs or layout issues. It would be a good idea to manually test these changes in various screen sizes and browsers to ensure they work as expected.

🔍🐞💻

Powered by Code Review GPT

@matthieujacq matthieujacq force-pushed the feat/full-size-chat-window branch from db84d52 to 5b2e396 Compare October 2, 2023 15:28
@matthieujacq matthieujacq temporarily deployed to preview October 2, 2023 15:28 — with GitHub Actions Inactive
@matthieujacq matthieujacq temporarily deployed to preview October 3, 2023 08:44 — with GitHub Actions Inactive
@matthieujacq matthieujacq temporarily deployed to preview October 3, 2023 09:23 — with GitHub Actions Inactive
@matthieujacq matthieujacq temporarily deployed to preview October 3, 2023 09:30 — with GitHub Actions Inactive
@matthieujacq matthieujacq temporarily deployed to preview October 3, 2023 09:48 — with GitHub Actions Inactive
@matthieujacq matthieujacq temporarily deployed to preview October 3, 2023 09:55 — with GitHub Actions Inactive
@matthieujacq matthieujacq marked this pull request as ready for review October 3, 2023 09:56
@matthieujacq matthieujacq temporarily deployed to preview October 3, 2023 10:09 — with GitHub Actions Inactive
@matthieujacq matthieujacq merged commit 18f76a5 into main Oct 3, 2023
8 checks passed
@StanGirard StanGirard mentioned this pull request Oct 3, 2023
Merged
@matthieujacq matthieujacq deleted the feat/full-size-chat-window branch October 4, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamadoudicko mamadoudicko mamadoudicko approved these changes

Assignees

@matthieujacq matthieujacq

Labels
area: frontend Related to frontend functionality or under the /frontend directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthieujacq @mamadoudicko