fix(question): fixed with user_settings

[StanGirard]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Checklist before requesting a review

Please delete options that are not relevant.

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented hard-to-understand areas
• I have ideally added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged

Screenshots (if appropriate):

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
docs	🔄 Building (Inspect)	Visit Preview	Oct 6, 2023 6:32pm
quivr-strapi	🔄 Building (Inspect)	Visit Preview	Oct 6, 2023 6:32pm
quivrapp	🔄 Building (Inspect)	Visit Preview	Oct 6, 2023 6:32pm

[github-actions]

Risk Level 2 - /home/runner/work/quivr/quivr/backend/routes/chat_routes.py

1. The delete_chat_from_db function catches all exceptions and simply prints them. This could make debugging difficult in the future as it swallows all errors. Consider logging the error message and re-throwing the exception or handling specific exceptions.

try:
    supabase_db.delete_chat_history(chat_id)
except Exception as e:
    logger.error(e)
    raise

2. The check_user_requests_limit function has a pass statement in the else clause. If there is no code to execute, consider removing the else clause altogether.

3. The is_model_ok variable is defined twice in the create_question_handler function. This could lead to confusion and potential bugs. Consider refactoring the code to define it only once.

4. The create_question_handler and create_stream_question_handler functions have a lot of duplicate code. Consider refactoring to a common function to improve maintainability and reduce potential for bugs.

5. The print statements in the create_stream_question_handler function could be replaced with proper logging for better traceability in a production environment.

logger.info(\"streaming\")

---

🐛🔄🔍

---

Powered by Code Review GPT

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ AttributeError: 'dict' object has no attribute 'models' /chat/{chat_id}/question View Issue

_{Did you find this useful? React with a 👍 or 👎}