Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove legacy header and footer #1509

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

matthieujacq
Copy link
Contributor

Description

Also add a back to chat button in the user page to make up for the loss of the legacy header.

Screenshots (if appropriate):

image

@matthieujacq matthieujacq self-assigned this Oct 26, 2023
@dosubot dosubot bot added the area: frontend Related to frontend functionality or under the /frontend directory label Oct 26, 2023
@matthieujacq matthieujacq temporarily deployed to preview October 26, 2023 15:52 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 4:10pm
quivr-strapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 4:10pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 4:10pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/user/page.tsx

The changes in this file seem to be mostly related to UI and UX improvements. However, there are a few points to consider:

  1. The t function is used for translation, but it's not clear if all the new keys (settings, brainUsage, etc.) are defined in the translation files.
  2. The redirectToLogin function is called if there is no session, but it's not clear if this function handles the redirection properly and if the user is informed about it.
  3. The UserStatistics component is added, but it's not clear what it does. If it involves heavy computations or data fetching, it might affect performance.

🌐🔀📊


Powered by Code Review GPT

@matthieujacq matthieujacq changed the title Feat: remove legacy header and footer feat: remove legacy header and footer Oct 26, 2023
@matthieujacq matthieujacq merged commit c2bf3ad into main Oct 26, 2023
4 checks passed
mamadoudicko pushed a commit that referenced this pull request Oct 30, 2023
🤖 I have created a release *beep* *boop*
---


## 0.0.99 (2023-10-27)

## What's Changed
* fix: minor fixes by @gozineb in
#1499
* feat: remove onboarding's feature flag by @matthieujacq in
#1501
* feat: update form content on magic link auth request by @mamadoudicko
in #1502
* feat: remove legacy header and footer by @matthieujacq in
#1509
* fix: black horizontal line sometimes appearing below section by
@matthieujacq in #1510
* Improve readme.md by @ankur0904 in
#1511
* refactor(settings tab): extract components by @gozineb in
#1335
* fix: hidden video playing automatically on iphone by @matthieujacq in
#1514

## New Contributors
* @ankur0904 made their first contribution in
#1511

**Full Changelog**:
v0.0.98...v0.0.99

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.99 (2023-10-27)

## What's Changed
* fix: minor fixes by @gozineb in
QuivrHQ/quivr#1499
* feat: remove onboarding's feature flag by @matthieujacq in
QuivrHQ/quivr#1501
* feat: update form content on magic link auth request by @mamadoudicko
in QuivrHQ/quivr#1502
* feat: remove legacy header and footer by @matthieujacq in
QuivrHQ/quivr#1509
* fix: black horizontal line sometimes appearing below section by
@matthieujacq in QuivrHQ/quivr#1510
* Improve readme.md by @ankur0904 in
QuivrHQ/quivr#1511
* refactor(settings tab): extract components by @gozineb in
QuivrHQ/quivr#1335
* fix: hidden video playing automatically on iphone by @matthieujacq in
QuivrHQ/quivr#1514

## New Contributors
* @ankur0904 made their first contribution in
QuivrHQ/quivr#1511

**Full Changelog**:
QuivrHQ/quivr@v0.0.98...v0.0.99

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to frontend functionality or under the /frontend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants