Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 telegram #1555

Merged
merged 1 commit into from
Nov 1, 2023
Merged

feat: 🎸 telegram #1555

merged 1 commit into from
Nov 1, 2023

Conversation

StanGirard
Copy link
Collaborator

added loaders and compatibility

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

added loaders and compatibility
@dosubot dosubot bot added the area: backend Related to backend functionality or under the /backend directory label Nov 1, 2023
@StanGirard StanGirard temporarily deployed to preview November 1, 2023 21:09 — with GitHub Actions Inactive
Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs 🔄 Building (Inspect) Visit Preview Nov 1, 2023 9:09pm
quivr-strapi 🔄 Building (Inspect) Visit Preview Nov 1, 2023 9:09pm
quivrapp 🔄 Building (Inspect) Visit Preview Nov 1, 2023 9:09pm

@StanGirard StanGirard merged commit 5eed1a0 into main Nov 1, 2023
6 of 10 checks passed
Copy link
Contributor

github-actions bot commented Nov 1, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/backend/loaders/telegram.py

The code is generally well-written and follows good practices. However, there is a potential issue with the concatenate_rows function. If the text_content is neither a string nor a list, it is set to an empty string. This could potentially lead to loss of data if text_content is of a different type. Consider adding an else clause to handle other types of text_content.


Risk Level 3 - /home/runner/work/quivr/quivr/backend/repository/brain/get_question_context_from_brain.py

The code has a potential bug in the loop where it removes documents after reaching a certain token limit. Modifying a list while iterating over it can lead to unexpected behavior. Consider creating a new list for the documents that should be kept instead of removing from the existing list. For example:

kept_documents = []
for doc in documents:
    tokens += len(doc.page_content) * 1.5
    if tokens > 3000:
        break
    kept_documents.append(doc)
documents = kept_documents

📝🐛🔄


Powered by Code Review GPT

mamadoudicko pushed a commit that referenced this pull request Nov 2, 2023
🤖 I have created a release *beep* *boop*
---


## 0.0.103 (2023-11-02)

## What's Changed
* feat: allow to share a public brain link by @mamadoudicko in
#1541
* fix: prompt update in brains management settings tab by @gozineb in
#1543
* refactor: extract prompt from settings by @gozineb in
#1546
* feat: 🎸 telegram by @StanGirard in
#1555
* feat: 🎸 telegram by @StanGirard in
#1559
* docs: update run_fully_local.md by @eltociear in
#1556
* docs: grammatical errors in README.md by @HimanshuMahto in
#1536
* fix: missing or inaccurate zh-cn translations by @jerryshang in
#1558

## New Contributors
* @HimanshuMahto made their first contribution in
#1536
* @jerryshang made their first contribution in
#1558

**Full Changelog**:
v0.0.102...v0.0.103

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
coolCatalyst added a commit to coolCatalyst/quivr that referenced this pull request Jun 1, 2024
🤖 I have created a release *beep* *boop*
---


## 0.0.103 (2023-11-02)

## What's Changed
* feat: allow to share a public brain link by @mamadoudicko in
QuivrHQ/quivr#1541
* fix: prompt update in brains management settings tab by @gozineb in
QuivrHQ/quivr#1543
* refactor: extract prompt from settings by @gozineb in
QuivrHQ/quivr#1546
* feat: 🎸 telegram by @StanGirard in
QuivrHQ/quivr#1555
* feat: 🎸 telegram by @StanGirard in
QuivrHQ/quivr#1559
* docs: update run_fully_local.md by @eltociear in
QuivrHQ/quivr#1556
* docs: grammatical errors in README.md by @HimanshuMahto in
QuivrHQ/quivr#1536
* fix: missing or inaccurate zh-cn translations by @jerryshang in
QuivrHQ/quivr#1558

## New Contributors
* @HimanshuMahto made their first contribution in
QuivrHQ/quivr#1536
* @jerryshang made their first contribution in
QuivrHQ/quivr#1558

**Full Changelog**:
QuivrHQ/quivr@v0.0.102...v0.0.103

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to backend functionality or under the /backend directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant