-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 telegram #1555
feat: 🎸 telegram #1555
Conversation
added loaders and compatibility
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Risk Level 2 - /home/runner/work/quivr/quivr/backend/loaders/telegram.py The code is generally well-written and follows good practices. However, there is a potential issue with the Risk Level 3 - /home/runner/work/quivr/quivr/backend/repository/brain/get_question_context_from_brain.py The code has a potential bug in the loop where it removes documents after reaching a certain token limit. Modifying a list while iterating over it can lead to unexpected behavior. Consider creating a new list for the documents that should be kept instead of removing from the existing list. For example: kept_documents = []
for doc in documents:
tokens += len(doc.page_content) * 1.5
if tokens > 3000:
break
kept_documents.append(doc)
documents = kept_documents 📝🐛🔄 Powered by Code Review GPT |
🤖 I have created a release *beep* *boop* --- ## 0.0.103 (2023-11-02) ## What's Changed * feat: allow to share a public brain link by @mamadoudicko in #1541 * fix: prompt update in brains management settings tab by @gozineb in #1543 * refactor: extract prompt from settings by @gozineb in #1546 * feat: 🎸 telegram by @StanGirard in #1555 * feat: 🎸 telegram by @StanGirard in #1559 * docs: update run_fully_local.md by @eltociear in #1556 * docs: grammatical errors in README.md by @HimanshuMahto in #1536 * fix: missing or inaccurate zh-cn translations by @jerryshang in #1558 ## New Contributors * @HimanshuMahto made their first contribution in #1536 * @jerryshang made their first contribution in #1558 **Full Changelog**: v0.0.102...v0.0.103 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## 0.0.103 (2023-11-02) ## What's Changed * feat: allow to share a public brain link by @mamadoudicko in QuivrHQ/quivr#1541 * fix: prompt update in brains management settings tab by @gozineb in QuivrHQ/quivr#1543 * refactor: extract prompt from settings by @gozineb in QuivrHQ/quivr#1546 * feat: 🎸 telegram by @StanGirard in QuivrHQ/quivr#1555 * feat: 🎸 telegram by @StanGirard in QuivrHQ/quivr#1559 * docs: update run_fully_local.md by @eltociear in QuivrHQ/quivr#1556 * docs: grammatical errors in README.md by @HimanshuMahto in QuivrHQ/quivr#1536 * fix: missing or inaccurate zh-cn translations by @jerryshang in QuivrHQ/quivr#1558 ## New Contributors * @HimanshuMahto made their first contribution in QuivrHQ/quivr#1536 * @jerryshang made their first contribution in QuivrHQ/quivr#1558 **Full Changelog**: QuivrHQ/quivr@v0.0.102...v0.0.103 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
added loaders and compatibility
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Checklist before requesting a review
Please delete options that are not relevant.
Screenshots (if appropriate):