Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add knowledge_brain #2988

Merged
merged 25 commits into from
Aug 20, 2024
Merged

Conversation

chloedia
Copy link
Collaborator

@chloedia chloedia commented Aug 9, 2024

I have made changes to the knowledge table schema and models to improve functionality and data organization. This includes adding new columns, modifying existing columns, and updating relationships. These changes will enhance the overall performance and usability of the application.

chloedia and others added 10 commits August 7, 2024 16:44
# Description

Please include a summary of the changes and the related issue. Please
also include relevant motivation and context.

## Checklist before requesting a review

Please delete options that are not relevant.

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented hard-to-understand areas
- [ ] I have ideally added tests that prove my fix is effective or that
my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged

## Screenshots (if appropriate):

---------

Co-authored-by: aminediro <aminedirhoussi1@gmail.com>
Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 0:49am

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. area: backend Related to backend functionality or under the /backend directory labels Aug 9, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 14, 2024
Copy link
Collaborator

@AmineDiro AmineDiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the PR ! Some changes but overall very solid work and huge amount of changes !

Copy link
Collaborator

@AmineDiro AmineDiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the changes. Minor changes to celery_worker and Embedding dim :+1

backend/api/quivr_api/models/settings.py Outdated Show resolved Hide resolved
backend/worker/quivr_worker/celery_monitor.py Show resolved Hide resolved
Copy link
Collaborator

@AmineDiro AmineDiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the work !

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 20, 2024
@AmineDiro AmineDiro merged commit 3f4c256 into release/quivr-core-0.1 Aug 20, 2024
5 of 6 checks passed
@AmineDiro AmineDiro deleted the release/fix/knowledge_brain branch August 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to backend functionality or under the /backend directory lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants