Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: syncs workers + notifier #2996

Merged
merged 9 commits into from
Aug 14, 2024
Merged

fix: syncs workers + notifier #2996

merged 9 commits into from
Aug 14, 2024

Conversation

AmineDiro
Copy link
Collaborator

Description

  • Complete rewrite of Syncutils
  • Eager processing Syncs on Create and Update Sync.
  • Simplified a LOT of filtering logic on files
  • Fixed notifier async knowledge

@vercel Vercel
Copy link

vercel bot commented Aug 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 7:54am

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. area: backend Related to backend functionality or under the /backend directory labels Aug 12, 2024
chloedia
chloedia approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@chloedia chloedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Good to me ! Nice PR !

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2024
@AmineDiro AmineDiro merged commit f832940 into release/quivr-core-0.1 Aug 14, 2024
5 checks passed
@AmineDiro AmineDiro deleted the fix/syncs-worker branch August 14, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanGirard StanGirard StanGirard left review comments

@chloedia chloedia chloedia approved these changes

Assignees
No one assigned
Labels
area: backend Related to backend functionality or under the /backend directory lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AmineDiro @StanGirard @chloedia