fix(pg-database): by default variable is not implemented

[StanGirard]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 4, 2023 8:17am
quivrapp	🔄 Building (Inspect)	Visit Preview		Aug 4, 2023 8:17am

[github-actions]

LOGAF Level 2 - /home/runner/work/quivr/quivr/backend/core/models/settings.py

1. Avoid code duplication: The settings = BrainSettings() line is repeated in multiple functions. Consider creating a global settings object that can be used across all functions. This will make your code DRY (Don't Repeat Yourself) and easier to maintain.

settings = BrainSettings()

def get_supabase_client() -> Client:
    supabase_client: Client = create_client(
        settings.supabase_url, settings.supabase_service_key
    )
    return supabase_client

2. Secure sensitive data: The BrainSettings class contains sensitive data such as API keys. Consider using environment variables to store these values securely. This will prevent accidental exposure of sensitive data.

import os

class BrainSettings(BaseSettings):
    openai_api_key: str = os.getenv('OPENAI_API_KEY')
    anthropic_api_key: str = os.getenv('ANTHROPIC_API_KEY')
    supabase_url: str = os.getenv('SUPABASE_URL')
    supabase_service_key: str = os.getenv('SUPABASE_SERVICE_KEY')
    pg_database_url: str = os.getenv('PG_DATABASE_URL', 'not implemented')
    resend_api_key: str = os.getenv('RESEND_API_KEY', 'null')
    resend_email_address: str = os.getenv('RESEND_EMAIL_ADDRESS', 'brain@mail.quivr.app')

---

🔂🌍🔒

---

Powered by Code Review GPT