Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(conversation): gave the user a bit more context on @ #994

Closed
wants to merge 2 commits into from

Conversation

StanGirard
Copy link
Collaborator

No description provided.

@StanGirard StanGirard temporarily deployed to preview August 21, 2023 09:17 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Aug 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 1:26pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 1:26pm

@@ -12,7 +12,7 @@
"receivedResponse": "Received response. Starting to handle stream...",
"errorCallingAPI": "Error calling the API",
"ask": "Ask a question, or describe a task.",
"begin_conversation_placeholder": "Begin conversation here...",
"begin_conversation_placeholder": "Begin conversation here, @ to select a brain or / to select a file",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The used one seems to be actions_bar_placeholder instead of begin_conversation_placeholder

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"/" to select a file does not exist yet

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@StanGirard StanGirard temporarily deployed to preview August 21, 2023 13:24 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Risk Level 3 - /home/runner/work/quivr/quivr/backend/crawl/crawler.py

The _crawl function prints the exception and then raises it again. This could lead to the same error being logged multiple times. Consider removing the print statement.

except Exception as e:
    raise

Risk Level 5 - /home/runner/work/quivr/quivr/backend/repository/user_identity/create_user_identity.py

The openai_api_key is being stored in plain text which is a serious security risk. It should be encrypted before being stored and decrypted when it needs to be used. This can be done using a library like cryptography.fernet.

from cryptography.fernet import Fernet
# Generate a key
key = Fernet.generate_key()
# Create the cipher suite
cipher_suite = Fernet(key)
# Encrypt the data
cipher_text = cipher_suite.encrypt(b\"openai_api_key\")
# Decrypt the data
plain_text = cipher_suite.decrypt(cipher_text)

Risk Level 5 - /home/runner/work/quivr/quivr/backend/repository/user_identity/update_user_properties.py

The openai_api_key is being stored in plain text which is a serious security risk. It should be encrypted before being stored and decrypted when it needs to be used. This can be done using a library like cryptography.fernet.

from cryptography.fernet import Fernet
# Generate a key
key = Fernet.generate_key()
# Create the cipher suite
cipher_suite = Fernet(key)
# Encrypt the data
cipher_text = cipher_suite.encrypt(b\"openai_api_key\")
# Decrypt the data
plain_text = cipher_suite.decrypt(cipher_text)

🐛🔐🔑


Powered by Code Review GPT

@StanGirard StanGirard closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants