Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling ECONNRESET caused when restarting browser process #79

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

kenpb
Copy link
Contributor

@kenpb kenpb commented Jan 2, 2018

Problem:

My electron-connect server was crashing with ECONNRESET every time the browser process was being restarted, this seems to be due to the client process being killed and the socket not being closed correctly.

Changes proposed:

  • Simply, make the wrapper throw any exception beside ECONNRESET

Copy link

@altsanz altsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has solved exactly the issue on my side.

@altsanz
Copy link

altsanz commented Jan 9, 2018

Issue #71 related?

@Quramy Quramy merged commit 8f75d52 into Quramy:master Jan 11, 2018
@Quramy
Copy link
Owner

Quramy commented Jan 11, 2018

@kenpb, thanks for your contributing and sorry for my late reply 🙇

I've released this change at v0.6.3 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants