Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic normalization bounds produce sub-optimal images #186

Closed
atruskie opened this issue Jul 31, 2018 · 5 comments · Fixed by #230
Closed

Automatic normalization bounds produce sub-optimal images #186

atruskie opened this issue Jul 31, 2018 · 5 comments · Fixed by #230
Assignees

Comments

@atruskie
Copy link
Member

Expected behaviour

False colour spectrograms, rendered for the zooming and fixed-scale visualisations should be similar or identical.

Actual behaviour

Due to the fact that the IndexPropertiesConfig.Zooming.yml config file uses automatic normalization bounds and the IndexPropertiesConfig.yml does not, the images rendered for zooming look different from those done by normal generation. In particular, they generally look very red,/green and at lower scales, very green.

If you look on Ecosounds and correlate the data there with images we produce offline, you'll find plenty of examples where the colour profiles are sub-optimal.

Here is one demo: This data was used in the workshop and is attributed to Liz Znidersic. It is from the Tasmania Mez site, on the 2015-11-14.

Here is a manually composited image of the zooming tiles:
composite_60 0

And the standard rendering (through Towsey.Acoustic):
sm304256_0 1_20151114__2maps

Steps to reproduce the behaviour

  • What command did you use?
    • The standard commands for generating indices (audio2csv and Towsey.Acoustic.yml) and generating zooming images (DrawZoomingSpectrograms)
  • What config file did you use?
    • The standard configs
    • A local copy here: \\Sef-bigdata-10\d$\tasmania_mez\Towsey.Acoustic.Zooming.yml
  • Where can we find the source data used?
    • \\Sef-bigdata-10\d$\tasmania_mez has a copy of the zooming indices and tiles

Any other details

This issue affects all images used for zooming spectrograms on the Ecosounds website. The changes made to normalization bounds should be tested for multiple zoom levels, and multiple sites.

@atruskie
Copy link
Member Author

atruskie commented Aug 3, 2018

@towsey did some work on this in ad1f0f8

@atruskie
Copy link
Member Author

atruskie commented Aug 9, 2018

@towsey - I remember what we were talking about now.

We were concerned that the histograms output for the zooming indices were very flat (and thus not useful for automated normalisation).

  • you were going to investigate why the BGN histogram had a weird gap in its distribution

  • we were going to check the histogram functions for soundness given the very large number of values involved (possible int32 overflow?)

  • Phil and I were discussing this:

    • We may need to calculate the distributions separately for each zoom level
    • Are confidence intervals useful here?
    • If you thought it was useful, we maybe should calculate index values and distributions for a significant (and random) subset of our entire audio collection (periodically) and use those fixed values in all zooming rendering. This would be an example of a offline analysis

@towsey
Copy link
Contributor

towsey commented Aug 9, 2018 via email

towsey added a commit that referenced this issue Mar 21, 2019
Use the full range of the y-axis scale when drawing histogram.
Add the number of the modal bin to the collected statistics.
Change method arguments to accept modalBin.
Remove duplicated lines from SpectrogramConstants.cs.
Write SandPit method to test drawing of histograms.
this can be turned into a unit test.
NOTE: The "gap" in the histograms noted in Issue #186 is due to way Rectangular bars were drawn. Nothing to do with inadequate size of int.
towsey added a commit that referenced this issue Mar 25, 2019
@atruskie atruskie reopened this Mar 25, 2019
@atruskie
Copy link
Member Author

More work is required for this.

We need to see

  • the 24-hour image generated from the zooming analysis
  • and the new distribution image

Keep in mind, this issue when closed will trigger a solid 6-9 months of computation as we update all the images on Ecosounds.

towsey added a commit that referenced this issue Aug 30, 2019
Issue #186 Fixed tests which failed when I did work on this issue.
Also removed an attempt to combine two index matrices into one.
towsey added a commit that referenced this issue Sep 4, 2019
Issue #186 - Fix problem with the ACI value in the top most freq bin. Explanation is given where the code has been changed. This change may cause unit tests to fail that depend on the ACI value in top freq bin.
atruskie added a commit that referenced this issue Sep 24, 2019
@atruskie
Copy link
Member Author

Closed in #233

towsey added a commit that referenced this issue Nov 12, 2019
This is quick fix for issue #186.
To fix spurious values in top bin of ACI spectral index. Set value in top bin to value in bin below.
towsey added a commit that referenced this issue Nov 12, 2019
Issue #186 required change to the expected ACI vector. Test is now passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants