Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added user timezone setting (defaults to Brisbane). #121

Closed
wants to merge 3 commits into from

Conversation

cofiem
Copy link
Contributor

@cofiem cofiem commented Sep 6, 2014

WARNING: finding original audio recordings may not work with user time zone other than Brisbane - test this!

Relates to #22 #23
Closes #24 #116

WARNING: finding original audio recordings may not work with user time zone other than Brisbane - test this!
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) when pulling 790ba84 on feature-time-zone-improvements into 29f17dc on develop.

@cofiem
Copy link
Contributor Author

cofiem commented Sep 7, 2014

Maybe use zonebie gem to check timezones in tests?

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.0%) when pulling 15528d2 on feature-time-zone-improvements into 29f17dc on develop.

@atruskie
Copy link
Member

atruskie commented Sep 7, 2014

Just off the top of my head I think the maintinance task (QutBioacoustics/baw-private#13 && #22 && #23) needs to preclude this change - for sanity's sake - pretty much like you already said.

Also what affects is this going to have on the API? I assume the time zone will be encoded (e.g. +08) with every date sent back?

@cofiem
Copy link
Contributor Author

cofiem commented Oct 3, 2014

Comments, useful links:

@cofiem
Copy link
Contributor Author

cofiem commented Feb 27, 2015

We need to record the utc offset and the time zone name. This will enable us to display the time in the time zone the audio recording was made. We do not want to display the time in the user's timezone - that makes no sense.

We will need to retroactively add utc offsets and time zone names to all recordings. @jwim1 will help with this.

@cofiem
Copy link
Contributor Author

cofiem commented Feb 27, 2015

Need to record utc offset at time of recording (as this could change due to changes in time zone e.g. DST start/end).
Need time to be able to know the time zone recording was made (for display and provenance).

@cofiem cofiem closed this Mar 7, 2015
@cofiem cofiem deleted the feature-time-zone-improvements branch March 7, 2015 10:35
@cofiem cofiem changed the title [WIP] Added user timezone setting (defaults to Brisbane). Added user timezone setting (defaults to Brisbane). May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove timezone configuration for brisbane
3 participants