-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added user timezone setting (defaults to Brisbane). #121
Conversation
WARNING: finding original audio recordings may not work with user time zone other than Brisbane - test this!
Maybe use zonebie gem to check timezones in tests? |
Just off the top of my head I think the maintinance task (QutBioacoustics/baw-private#13 && #22 && #23) needs to preclude this change - for sanity's sake - pretty much like you already said. Also what affects is this going to have on the API? I assume the time zone will be encoded (e.g. +08) with every date sent back? |
Comments, useful links:
|
We need to record the utc offset and the time zone name. This will enable us to display the time in the time zone the audio recording was made. We do not want to display the time in the user's timezone - that makes no sense. We will need to retroactively add utc offsets and time zone names to all recordings. @jwim1 will help with this. |
Need to record utc offset at time of recording (as this could change due to changes in time zone e.g. DST start/end). |
WARNING: finding original audio recordings may not work with user time zone other than Brisbane - test this!
Relates to #22 #23
Closes #24 #116