Checks that post params is not empty for update and create #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and create If there are no params, determines whether the request body was empty or if it just was not parsed properly, and responds with approprtiate error code depending on the situation. If the body was empty, includes an error link to the new action. If the body was not empty, responds with unsupported_media_type.
atruskie
requested changes
Aug 23, 2018
| # an empty body parsed as json will have the form {model => {}} | ||
| # json body with application/x-www-form-urlencoded content type will have the form {json_string => {}} | ||
| # json or form encoded with text/plain content type will have the form {} | ||
| if request.POST.values.all? { |val| val.nil? || (val.is_a?(Hash) && val.empty?) } |
There was a problem hiding this comment.
Simplify this predicate by using .blank?
| # json or form encoded with text/plain content type will have the form {} | ||
| if request.POST.values.all? { |val| val.nil? || (val.is_a?(Hash) && val.empty?) } | ||
|
|
||
| if (request.body.string == "") |
There was a problem hiding this comment.
More idiomatic ruby would use .blank? or .empty?. Also I believe the parentheses are not needed here
| message = "Failed to parse the request body. Ensure that it is formed correctly and matches the content-type (#{request.content_type})" | ||
| end | ||
| end | ||
| render_error(status, message,nil,'validate_contains_params', options) |
spec/requests/dataset_items_spec.rb
Outdated
| @env['HTTP_AUTHORIZATION'] = admin_token | ||
|
|
||
| @create_dataset_item_url = "/datasets/" + dataset.id.to_s + "/items" | ||
| @update_dataset_item_url = "/datasets/" + dataset_item.dataset_id.to_s + "/items/" + dataset_item.id.to_s |
There was a problem hiding this comment.
Can we use url_helpers here? Or any rails method for generating the route?
If not, if you use string interpolation (which should do the .to_s part for you).
| @env['CONTENT_TYPE'] = "application/json" | ||
| params = nil | ||
| post @create_dataset_item_url, params, @env | ||
| expect(response).to have_http_status(400) |
There was a problem hiding this comment.
should this test have a new resource link as well (like the test below)?
| put @update_dataset_item_url, params, @env | ||
| expect(response).to have_http_status(200) | ||
| end | ||
|
|
There was a problem hiding this comment.
the update route doesn't get the empty body (400 response) tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #366. Fixes #361.
If there are no params, determines whether the request body was empty or if it just was not parsed properly, and responds with approprtiate error code depending on the situation.
If the body was empty, includes an error link to the new action.
If the body was not empty, responds with unsupported_media_type.