Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing site model details #463

Merged
merged 8 commits into from
Jun 4, 2020
Merged

Missing site model details #463

merged 8 commits into from
Jun 4, 2020

Conversation

Allcharles
Copy link
Collaborator

Missing Site Model Details

Updated the filter_settings output of the sites model

Changes

  • Extracted image_urls from User model into Api::Image.image_urls so that it is reusable for other models
  • Updated document formatting to be compatible with rubocop for some files
  • Added model output checking for INDEX site route
  • Modified filter_settings for Site model

Closes

Closes #453

Added the following details:
- image_urls
- creator_id
- updater_id
- created_at
- updated_at

Extracted image_urls functionality from user model into Api::Image module
.rubocop.yml Outdated Show resolved Hide resolved
spec/acceptance/sites_spec.rb Outdated Show resolved Hide resolved
spec/models/site_spec.rb Outdated Show resolved Hide resolved
@atruskie atruskie merged commit 4414944 into master Jun 4, 2020
@Allcharles Allcharles deleted the missing-site-model-details branch June 4, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing site model details
2 participants