Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an automatic changelog generator #483

Merged
merged 3 commits into from
Jul 29, 2020
Merged

Conversation

atruskie
Copy link
Member

@atruskie atruskie commented Jul 28, 2020

Added instructions for creating releases

Changes

Invocation is manual at the moment since I don't have a neat way to auto-generate version numbers.

Also deleteded old travis file and updated docs.

Problems

Can't figure out a sane way to auto increment versions. For now, leaving the version in the VERSION file should make this easy to script later on.

Visual Changes

N/A

Final Checklist

  • Assign reviewers if you have permission
  • Assign labels if you have permission
  • Link issues related to PR
  • Remove/Reduce warnings from edited files
  • Unit tests have been added for changes
  • Ensure CI build is passing

Invocation is manual at the moment since I don't have a neat way to auto-generate version numbers.

Also deleteded old travis file and updated docs.
@atruskie atruskie added the docs label Jul 28, 2020
@atruskie atruskie requested a review from Allcharles July 28, 2020 14:19
Copy link
Collaborator

@Allcharles Allcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm surprised the ruby ecosystem doesn't have somewhere already set which defines the version of a project, similar to the package.json file in node.

HISTORY.md Show resolved Hide resolved
@atruskie
Copy link
Member Author

Looks good. I'm surprised the ruby ecosystem doesn't have somewhere already set which defines the version of a project, similar to the package.json file in node.

They do for Gems (packages). The .gemspec has a version field. Most libs simply define a VERSION constant in the root module. But it doesn't seem there is a consistent method for rails. I kept it in settings simply because that is where it was before 🤷‍♂️

@atruskie atruskie merged commit e4c182b into master Jul 29, 2020
@atruskie atruskie deleted the changelog-generation branch July 29, 2020 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants