Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permissions endpoint #559

Merged
merged 7 commits into from
Mar 9, 2022
Merged

Permissions endpoint #559

merged 7 commits into from
Mar 9, 2022

Conversation

yupengKenny
Copy link
Contributor

@yupengKenny yupengKenny commented Mar 7, 2022 •
edited by atruskie
Loading

Add tests for permissions endpoint

Adds tests and proper API functionality for the permissions endpoint.

Fixes #432

Changes

  • added permissions, docs, and request specs for permissions endpoint
  • updated some actions and permissions to reflect standard API best practices

Problems

Still needs work

Visual Changes

N/A

Final Checklist

  • Assign reviewers if you have permission
  • Assign labels if you have permission
  • Link issues related to PR
  • Remove/Reduce warnings from edited files
  • Unit tests have been added for changes
  • Ensure CI build is passing

@yupengKenny yupengKenny requested a review from atruskie March 7, 2022 04:10
@atruskie atruskie self-assigned this Mar 7, 2022
Allcharles
Allcharles approved these changes Mar 7, 2022
View reviewed changes
Copy link
Collaborator

@Allcharles Allcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions, overall looks fine

app/models/ability.rb Outdated Show resolved Hide resolved
app/models/ability.rb Outdated Show resolved Hide resolved
app/models/permission.rb Outdated Show resolved Hide resolved
spec/helpers/factory_bot_helpers.rb Show resolved Hide resolved
spec/requests/permissions.rb Outdated Show resolved Hide resolved
test.txt Outdated Show resolved Hide resolved
spec/requests/permissions/permission_spec.rb Outdated Show resolved Hide resolved
@atruskie atruskie force-pushed the permissions-endpoint branch from 4fcbf8e to 732c8fc Compare March 8, 2022 13:06
atruskie added 4 commits March 9, 2022 12:42
@atruskie
Fixed tests
f9ba405 
Removed old permissions acceptance tests - they're fully covered by
other tests now.

Breaking: normalized permission levels to lower case forms for project
model responses. I.e. `Owner` is now `owner`.
@atruskie
Update sftpgo support files
758ecce 
A new version brought some breaking changes to config file and responses.
@atruskie
Add missing routing specs for regions endpoint
a1e54ec
@atruskie
Update debugging instructions
61ac645
@atruskie atruskie merged commit 61ac645 into master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Allcharles Allcharles Allcharles approved these changes

@atruskie atruskie Awaiting requested review from atruskie

Assignees

@atruskie atruskie

Labels
API enhancement feature: projects triage:low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing project individual user permissions route
3 participants
@yupengKenny @atruskie @Allcharles