Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Update Mapbox-GL to v1.13.0 #943

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Update Mapbox-GL to v1.13.0 #943

merged 2 commits into from
Nov 30, 2020

Conversation

bbecquet
Copy link
Contributor

@bbecquet bbecquet commented Nov 26, 2020

Description

Update from v1.11.1 to v1.13.0.
Changelog: https://github.com/mapbox/mapbox-gl-js/releases

It required some changes in the CSS used to override the style of the compact attribution control on mobile, as it was changed in mapbox/mapbox-gl-js#9991, mostly introducing a real <button> for a11y reasons.
I cleaned up some stuff in the process, as such overrides where scattered in 3 different files. Now everything is in map_theme.scss.

@bbecquet bbecquet requested review from amatissart and G-Ray November 26, 2020 09:32
@amatissart
Copy link
Contributor

The compact attribution icon is no longer visible on mobile (next to the scale).
It's probably related to the change discussed in mapbox/mapbox-gl-js#9991 that may conflict with our css overrides.

@bbecquet
Copy link
Contributor Author

@amatissart indeed! It passed through my check. Thanks!

@bbecquet bbecquet merged commit 6596c6f into Qwant:master Nov 30, 2020
@bbecquet bbecquet deleted the mapbox-gl-1.13 branch November 30, 2020 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants