This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Minor adjustments on instant answers triggers and normalization #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-dupre
previously approved these changes
Mar 2, 2021
bbecquet
reviewed
Mar 2, 2021
| @@ -23,3 +23,4 @@ lieu dit | |||
| localisation | |||
| o(ù|u) (se|ce) (trouve|situe)( (le|la))? | |||
| where is | |||
| booking$ | |||
There was a problem hiding this comment.
Why did we choose to match only at the end of the string?
There was a problem hiding this comment.
To reduce the risk of false positives, when the keyword may be helpful to recognize and classify other types of intention.
When associated to a hotel name, "booking" appears almost always at the end of the query (statistically).
amatissart
force-pushed
the
ia-patterns-booking
branch
from
244edee
to
36c39b8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After internal feedbacks and observations of my own.