This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Add new block: social #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbecquet
reviewed
Jul 1, 2021
amatissart
reviewed
Jul 1, 2021
idunn/places/pj_poi.py
Outdated
Comment on lines
290
to
294
| suggested_label = self.data.website_urls[0].suggested_label | ||
| suggested_label = self.get_website_url_for_type(UrlType.EXTERNAL_WEBSITE) |
There was a problem hiding this comment.
So the suggested_label field provided by the API is no longer used ?
There was a problem hiding this comment.
That's fixed, and also the lack of test 😅
bbecquet
reviewed
Jul 1, 2021
bbecquet
approved these changes
Jul 1, 2021
amatissart
approved these changes
Jul 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new links for facebook, twitter, instagram and youtube (this last one is not really a social network but it has consequent coverage on OSM). Additionally, Facebook links won't be used anymore as websites urls (previously as a fallback for OSM and depending on the order for PJ).
I couldn't find any example of PJ places with an Instagram link so I didn't include it here :/