This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
explicitly set project name for tests's docker compose #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into an issue with my current setup (on both laptops, so that's most likely an issue with docker-compose 2.2, and not specific to my new installation), tests are able to spawn docker containers but won't be able to find them.
I've filed an issue on lovelysystems/lovely-pytest-docker#27, but in the mean time we can explicitly set the project name in
conftest.py. This will also spawn more human readable docker images during tests (idunn_test-mimir_es-1instead of$HOME/path/to/idunn-mimir_es-1.