Fixes #26 - Rollup not resolving path aliases on build. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PD: I forgot to mention, I also removed all the test comments of the Counter component and fixed the initial value, which was inside the props but not actually used. |
|
Awesome work! Went through it and looks good. Merging Also thank you for cleaning up our demo example, yeah I previously had content there to test named slots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #26. Turns out Qwik doesn't resolve the
pathsin thetsconfig.jsonout of the box. You need the vite pluginvite-tsconfig-pathsas done in the docs. The custombuildstep didn't resolve the paths because of the missing plugin.