Iframe Javascript URLs #122
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/builder-io/partytown/J75Mt7U2yuPjQ8bptouywxPBqmPB |
src/lib/web-worker/worker-iframe.ts
Outdated
| @@ -35,10 +35,18 @@ export const patchHTMLIFrameElement = (WorkerHTMLIFrameElement: any, env: WebWor | |||
|
|
|||
| src: { | |||
| get() { | |||
| let src = getIframeEnv(this).$location$.href; | |||
| let src = getter(this, ['src']); | |||
There was a problem hiding this comment.
Is there a way to do this without using getter() which is doing a call to the main thread? Could you try using getInstanceStateValue() and setInstanceStateValue() value instead so the value stays on the worker thread? The anchor element does something like this: https://github.com/BuilderIO/partytown/blob/1e2fac14760895e8e6d8624236ae550b584b2995/src/lib/web-worker/worker-anchor.ts#L14
There was a problem hiding this comment.
Thanks for that 🙏 I just used getInstanceStateValue() and setInstanceStateValue() to avoid calls to the main thread
src/lib/web-worker/worker-node.ts
Outdated
| @@ -69,6 +69,11 @@ export const createNodeCstr = ( | |||
| if (isIFrame) { | |||
| // an iframe element's instanceId is also | |||
| // the winId of its contentWindow | |||
| const src = getter(newNode, ['src']); | |||
There was a problem hiding this comment.
Same comment as before, and try to avoid using getter()
There was a problem hiding this comment.
Using getInstanceStateValue() now
src/lib/types.ts
Outdated
| @@ -524,6 +524,7 @@ export const enum NodeName { | |||
| export const enum StateProp { | |||
| errorHandlers = 'error', | |||
| loadHandlers = 'load', | |||
| src = 'src', | |||
There was a problem hiding this comment.
Is this guy ok or should it be a number?
There was a problem hiding this comment.
A number would be fine.
There was a problem hiding this comment.
Thanks, just updated it :)
montalvomiguelo
force-pushed
the
iframe-js-in-urls
branch
from
f88fe2c to
53d17b5
Compare
* using getInstanceStateValue() instead of getter() * using setInstanceStateValue() instead of setter()
montalvomiguelo
force-pushed
the
iframe-js-in-urls
branch
from
20fadd5 to
10d5ffe
Compare
|
awesome thanks! |
This MR allows us to execute scripts from Javascript URLs