Add support for passing functions in mainWindowAccessors
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looking forward for this fix. Thanks @slawekkolodziej |
slawekkolodziej
changed the title
mainWindowAccessors
|
Awesome work, thanks! |
|
@slawekkolodziej nice one do you mind sharing the code related to - It also requires GTM-specific code that tunnels messages from worker back to the Tag Assistant Companion. |
|
I posted some details in #72. I may create a react component with 'GTM snippet' and put it on npm for the ease of use, but I don't have time for that now. |
|
How can this be used to get Google Tag Assistant working? I feel like there's an undocumented step? Which function should be exposed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently stumbled upon
mainWindowAccessors. I thought it would be cool if this could forward function calls too.The implementation appeared to be relatively easy - I just added
callMethodinsideworker-serialization.ts. I didn't find any downsides of my change yet, but I would like to see another opinion.This change along with my other PR (#172) allowed me to integrate GTM Tag Assistant with Partytown inside Next.js app (#72).
partytown-gtm.mp4
What you see on the video above is Tag Assistant communicating with GTM running inside Partytown. It requires Tag Assistant Companion browser plugin. Change in Partytown is not enough to get this working. It also requires GTM-specific code that tunnels messages from worker back to the Tag Assistant Companion.