Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve SvelteKit docs #514

Merged
merged 1 commit into from
Dec 18, 2023
Merged

docs: improve SvelteKit docs #514

merged 1 commit into from
Dec 18, 2023

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Dec 17, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

  • Remove an unnecessary step
  • Put the optional step at the end
  • Put the two steps editing the same file next to each other

Reviewing the table of contents in lines 7-10 will help understand this change

Use cases and why

svelte-preprocess has been updated such that this option is no longer necessary. See sveltejs/svelte-preprocess#622 for more details

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

vercel bot commented Dec 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
partytown ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2023 4:11pm

@benmccann benmccann changed the title docs: remove unnecessary step from SvelteKit docs docs: remove unnecessary step from SvelteKit docs and reorder steps Dec 17, 2023
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benmccann for your improvements.

@gioboa
Copy link
Member

gioboa commented Dec 18, 2023

@benmccann just out of curiosity, what integrations are you managing in SvelteKit with PartyTown?

@benmccann
Copy link
Contributor Author

Just Google Analytics at the moment. I'm using it just on my own site currently, but am trying to think about how we might promote or integrate it in the framework to help a larger set of users. I have run into two issues with it though. One I need to investigate more to understand if it's from Partytown or SvelteKit, etc. The other I just filed a couple of days ago: #513

@gioboa
Copy link
Member

gioboa commented Dec 18, 2023

Feel free to share your feedback 👍
Thanks for your help @benmccann

@gioboa gioboa changed the title docs: remove unnecessary step from SvelteKit docs and reorder steps docs: improve SvelteKit docs Dec 18, 2023
@gioboa gioboa merged commit 07e6a0f into QwikDev:main Dec 18, 2023
11 checks passed
@benmccann benmccann deleted the sk-docs branch December 18, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants