fix: add document.scripts & tests #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
burakbasbug
force-pushed
the
fix/add-document-scripts-access
branch
from
4384fea to
2bc0458
Compare
gioboa
approved these changes
Dec 20, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
document.scripts(orwindow.document.scripts)Accessing
document.scripts.lengthtriggers an error becausedocument.scriptsyieldsundefined. This issue arises from attempting to retrieve the length property of an undefined object, causing a code execution error in context of partytown workers.Use cases and why
Use case: we tried migrating Google publisher tag scripts into Partytown on our website (https://automobile.nau.ch/) and got following error:
It can be reproduced by running any code that accesses the properties of
document.scripts(or window.document.scripts)Checklist: