feat: loadScriptsOnMainThread string[] -> (string | RegExp)[] #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dymoo
changed the title
gioboa
reviewed
Dec 26, 2023
Co-authored-by: Giorgio Boa <35845425+gioboa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Allow string OR RegExp to be passed into loadScriptsOnMainThread to avoid doing string-to-string comparison that doesn't work if the script has URL params.
Use cases and why
Google tag manager tag helper passes different URL params to the googletagmanager.com/debug/bootstrap script meaning string equality check won't work.
The following would now work
loadScriptsOnMainThread={[ /googletagmanager.com\/debug\/bootstrap/ ]}Would work.
mentioned by #477
Checklist: