fix: (worker-window): polyfill CSSMediaRule - copy from the PR #614 #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I modified the test on the 9d818eb commit so you can see the error, that observer is making clarity not work, so it doesn´t give an error, so I removed the observer and then clarity actually starts and then you get an error: |
|
idk why |
AndreAzevedoCoder
changed the title
gioboa
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
This PR is a copy from #614 that PR should go in because third-parties like clarity are still broken
Include polyfill for CSSMediaRule (used by hubspot tracking js)
Use cases and why
error when using clarity:
Hubspot references CSSMediaRule in their JS and it is currently failing because it doesn't exist in worker context.
We already have the polyfill for CSSStyleSheet and CSSMediaRule has the same interface so the same polyfill should work!
Checklist: