fix delete store property

QwikDev · Sep 17, 2024 · 98e9e08 · 98e9e08
1 parent 7600594
commit 98e9e08
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/packages/qwik/src/core/v2/signal/v2-store.ts b/packages/qwik/src/core/v2/signal/v2-store.ts
@@ -167,6 +167,7 @@ export class StoreHandler implements ProxyHandler<TargetType> {
  if (typeof prop != 'string' || !delete target[prop]) {
  return false;
  }
+ triggerEffects(this.$container$, this, getEffects(target, prop, this.$effects$));
  return true;
  }
 

diff --git a/packages/qwik/src/core/v2/tests/use-store.spec.tsx b/packages/qwik/src/core/v2/tests/use-store.spec.tsx
@@ -595,6 +595,30 @@ describe.each([
  expect((global as any).logs).toEqual([false, true]);
  });
 
+ it('should trigger effects on property delete', async () => {
+ const Cmp = component$(() => {
+ const store = useStore<{ delete?: string }>({ delete: 'test' });
+ return <div onClick$={() => delete store.delete}>{store.delete}</div>;
+ });
+
+ const { vNode, document } = await render(<Cmp />, { debug });
+ expect(vNode).toMatchVDOM(
+ <Component>
+ <div>
+ <Signal>{'test'}</Signal>
+ </div>
+ </Component>
+ );
+ await trigger(document.body, 'div', 'click');
+ expect(vNode).toMatchVDOM(
+ <Component>
+ <div>
+ <Signal></Signal>
+ </div>
+ </Component>
+ );
+ });
+
  describe('regression', () => {
  it('#5597 - should update value', async () => {
  (globalThis as any).clicks = 0;