-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: added Package manager tabs #5174
Conversation
👷 Deploy request for qwik-insights pending review.Visit the deploys page to approve it
|
This is so cool. Thanks 🚀 |
Qwik UI has tabs component, I think we can use that instead of a completely fresh implementation. What do you think @shairez ? |
great work @the-r3aper7 ! Yeah I agree @gioboa You can use the headless component and just match to the styles you've written There's even a shorthand syntax version to write a simple tabs component - <Tabs>
<TabPanel title="Tab 1">Content 1</TabPanel>
<TabPanel title="Tab 2">Content 2</TabPanel>
<TabPanel title="Tab 3">Content 3</TabPanel>
</Tabs> |
how can i resolve this conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. The changes look great, but this PR will have to wait until #5097 is resolved.
Yep, if it was a specific problem of Qwik UI I would have suggested to merge something simpler, but we need to fix this in Qwik anyway, so I think it's better wait a bit and use Qwik UI for an accessible tabs component. |
@the-r3aper7 the issue with Qwik UI is solved. |
i will complete the remaining work and make a PR by tomorrow currently i am travelling. |
i have created a new PR regarding this to avoid any conflicts. I am closing this now |
Overview
What is it?
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Use cases and why
Checklist: