Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(v2/ssr-container): rename ContainerElementFrame to ElementFrame #6551

Merged
merged 1 commit into from
Jun 23, 2024
Merged

refactor(v2/ssr-container): rename ContainerElementFrame to ElementFrame #6551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/qwik/src/server/v2-ssr-container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,13 @@ class StringBufferWriter {
}
}

interface ContainerElementFrame {
interface ElementFrame {
/*
* Used during development mode to track the nesting of HTML tags
* in order provide error messages when the nesting is incorrect.
*/
tagNesting: TagNesting;
parent: ContainerElementFrame | null;
parent: ElementFrame | null;
/** Element name. */
elementName: string;
/**
Expand Down Expand Up @@ -187,7 +187,7 @@ class SSRContainer extends _SharedContainer implements ISSRContainer {
private currentComponentNode: ISsrNode | null = null;
private styleIds = new Set<string>();

private currentElementFrame: ContainerElementFrame | null = null;
private currentElementFrame: ElementFrame | null = null;

private renderTimer: ReturnType<typeof createTimer>;
/**
Expand Down Expand Up @@ -985,11 +985,11 @@ class SSRContainer extends _SharedContainer implements ISSRContainer {
if (!this.currentElementFrame) {
tagNesting = initialTag(elementName);
} else {
let frame: ContainerElementFrame | null = this.currentElementFrame;
let frame: ElementFrame | null = this.currentElementFrame;
const previousTagNesting = frame!.tagNesting;
tagNesting = isTagAllowed(previousTagNesting, elementName);
if (tagNesting === TagNesting.NOT_ALLOWED) {
const frames: ContainerElementFrame[] = [];
const frames: ElementFrame[] = [];
while (frame) {
frames.unshift(frame);
frame = frame.parent;
Expand Down Expand Up @@ -1021,7 +1021,7 @@ class SSRContainer extends _SharedContainer implements ISSRContainer {
}
}
}
const frame: ContainerElementFrame = {
const frame: ElementFrame = {
tagNesting,
parent: this.currentElementFrame,
elementName,
Expand Down
Loading