Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2/ssr-container): add context to tag nesting property #6552

Conversation

naorpeled
Copy link
Member

@naorpeled naorpeled commented Jun 15, 2024

Overview

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

During a session with @mhevery and @shairez,
we looked at the SSR container class,
@mhevery explained what tagNesting means and I found this as something that is not intuitive so went ahead and opened this PR to add some context to it.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

netlify bot commented Jun 15, 2024

👷 Deploy request for qwik-insights pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e641bfe

@naorpeled naorpeled changed the title docs(v2/ssr-container): add context to tag nesting docs(v2/ssr-container): add context to tag nesting property Jun 15, 2024
@naorpeled naorpeled changed the base branch from main to build/v2 June 15, 2024 17:52
@naorpeled naorpeled marked this pull request as ready for review June 15, 2024 18:06
@naorpeled naorpeled requested a review from a team as a code owner June 15, 2024 18:06
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @naorpeled this could be useful for everyone 👍

@gioboa gioboa enabled auto-merge (squash) June 15, 2024 18:10
@shairez shairez disabled auto-merge June 15, 2024 20:24
@gioboa gioboa enabled auto-merge (squash) June 15, 2024 20:28
@gioboa gioboa disabled auto-merge June 15, 2024 21:46
@gioboa gioboa merged commit eefc38b into QwikDev:build/v2 Jun 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants