Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix the same task duplicates in serialized state #6623

Merged
merged 8 commits into from
Jul 1, 2024

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Jun 30, 2024

This PR fixes task serialization and removes the same task duplicates

@Varixo Varixo requested a review from a team as a code owner June 30, 2024 18:20
Copy link

cloudflare-workers-and-pages bot commented Jun 30, 2024

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e6d400d
Status:🚫  Build failed.

View logs

@Varixo Varixo marked this pull request as draft June 30, 2024 18:50
@Varixo Varixo marked this pull request as ready for review June 30, 2024 20:12
@shairez
Copy link
Contributor

shairez commented Jul 1, 2024

@Varixo thanks!

This is the error from CF pages -

23:19:55.904 | > qwik-monorepo@2.0.0-0 build.packages.docs /opt/buildhome/repo
23:19:55.904 | > pnpm -C ./packages/docs/ run build
23:19:55.904 |  
23:19:56.351 |  
23:19:56.351 | > qwik-docs@0.0.1 build /opt/buildhome/repo/packages/docs
23:19:56.351 | > qwik build
23:19:56.351 |  
23:19:56.409 | node:internal/modules/cjs/loader:1147
23:19:56.409 | throw err;
23:19:56.409 | ^
23:19:56.409 |  
23:19:56.410 | Error: Cannot find module './dist/cli.cjs'
23:19:56.410 | Require stack:
23:19:56.410 | - /opt/buildhome/repo/packages/qwik/qwik-cli.cjs
23:19:56.410 | at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15)
23:19:56.410 | at Module._load (node:internal/modules/cjs/loader:985:27)
23:19:56.410 | at Module.require (node:internal/modules/cjs/loader:1235:19)
23:19:56.410 | at require (node:internal/modules/helpers:176:18)
23:19:56.410 | at Object.<anonymous> (/opt/buildhome/repo/packages/qwik/qwik-cli.cjs:3:14)
23:19:56.410 | at Module._compile (node:internal/modules/cjs/loader:1376:14)
23:19:56.411 | at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
23:19:56.411 | at Module.load (node:internal/modules/cjs/loader:1207:32)
23:19:56.411 | at Module._load (node:internal/modules/cjs/loader:1023:12)
23:19:56.411 | at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12) {
23:19:56.411 | code: 'MODULE_NOT_FOUND',
23:19:56.411 | requireStack: [ '/opt/buildhome/repo/packages/qwik/qwik-cli.cjs' ]
23:19:56.412 | }
23:19:56.412

is it known? can we merge regardless?

@Varixo
Copy link
Member Author

Varixo commented Jul 1, 2024

@Varixo thanks!

This is the error from CF pages -

23:19:55.904 | > qwik-monorepo@2.0.0-0 build.packages.docs /opt/buildhome/repo
23:19:55.904 | > pnpm -C ./packages/docs/ run build
23:19:55.904 |  
23:19:56.351 |  
23:19:56.351 | > qwik-docs@0.0.1 build /opt/buildhome/repo/packages/docs
23:19:56.351 | > qwik build
23:19:56.351 |  
23:19:56.409 | node:internal/modules/cjs/loader:1147
23:19:56.409 | throw err;
23:19:56.409 | ^
23:19:56.409 |  
23:19:56.410 | Error: Cannot find module './dist/cli.cjs'
23:19:56.410 | Require stack:
23:19:56.410 | - /opt/buildhome/repo/packages/qwik/qwik-cli.cjs
23:19:56.410 | at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15)
23:19:56.410 | at Module._load (node:internal/modules/cjs/loader:985:27)
23:19:56.410 | at Module.require (node:internal/modules/cjs/loader:1235:19)
23:19:56.410 | at require (node:internal/modules/helpers:176:18)
23:19:56.410 | at Object.<anonymous> (/opt/buildhome/repo/packages/qwik/qwik-cli.cjs:3:14)
23:19:56.410 | at Module._compile (node:internal/modules/cjs/loader:1376:14)
23:19:56.411 | at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
23:19:56.411 | at Module.load (node:internal/modules/cjs/loader:1207:32)
23:19:56.411 | at Module._load (node:internal/modules/cjs/loader:1023:12)
23:19:56.411 | at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12) {
23:19:56.411 | code: 'MODULE_NOT_FOUND',
23:19:56.411 | requireStack: [ '/opt/buildhome/repo/packages/qwik/qwik-cli.cjs' ]
23:19:56.412 | }
23:19:56.412

is it known? can we merge regardless?

Yes. In the current state the docs are not building in v2, because of dependecies

@Varixo Varixo merged commit a5f9276 into build/v2 Jul 1, 2024
22 of 23 checks passed
@Varixo Varixo deleted the ds/doubled-task-instance branch July 1, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants