Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show a warning instead of an error for rerunning tasks on a different host #6635

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

dmitry-stepanenko
Copy link
Contributor

This is a fix for a toggle e2e test

Instead of throwing an error we will show a warning now

Copy link

cloudflare-workers-and-pages bot commented Jul 2, 2024

Deploying qwik-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 710b227
Status:🚫  Build failed.

View logs

@dmitry-stepanenko dmitry-stepanenko marked this pull request as ready for review July 2, 2024 18:36
@dmitry-stepanenko dmitry-stepanenko requested a review from a team as a code owner July 2, 2024 18:36
@Varixo
Copy link
Member

Varixo commented Jul 2, 2024

I think we should remove "skip" from the toggle test too

@Varixo Varixo merged commit b147210 into build/v2 Jul 4, 2024
22 of 23 checks passed
@Varixo Varixo deleted the ds/fix-toggle-e2e branch July 4, 2024 19:22
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmitry-stepanenko 👏🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants