Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): q-ignore and q-container-island implementation #6721

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Jul 24, 2024

This PR adds the q-ignore and the q-container-island comments.

Example:

<div>interactive content 1</div>
<!--q:ignore=FOO-->
...(ignored)
   <!--q:container-island=BAR-->
   <button on:click="...">some interactive island</button>
   <!--/q:container-island-->
...(ignored)
<!--/q:ignore-->
<div>interactive content 2</div>

@Varixo Varixo requested a review from a team as a code owner July 24, 2024 19:57
Copy link

changeset-bot bot commented Jul 24, 2024

⚠️ No Changeset found

Latest commit: 8a9f681

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mhevery mhevery merged commit ea2a48c into build/v2 Jul 24, 2024
25 checks passed
@mhevery mhevery deleted the varixo/q-ignore-impl branch July 24, 2024 21:28
@Varixo Varixo self-assigned this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants