Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove Cannot resolve symbol from the integration tests in v2 #6737

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Jul 29, 2024

Overview

https://github.com/orgs/QwikDev/projects/1/views/1?pane=issue&itemId=68407338

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Use cases and why

    1. One use case
    1. Another use case

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested a review from a team as a code owner July 29, 2024 02:09
Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: 9f817f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@Varixo Varixo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct fix. You shoudn't remove the error message from the code. Instead you need to find why this message is appearing and do something inside the tests

@JerryWu1234 JerryWu1234 marked this pull request as draft July 29, 2024 05:35
@JerryWu1234
Copy link
Contributor Author

image

This is not the correct fix. You shoudn't remove the error message from the code. Instead you need to find why this message is appearing and do something inside the tests

Sorry, I got it wrong.

I finish it now. I tweak the unit tests

@JerryWu1234 JerryWu1234 marked this pull request as ready for review July 29, 2024 07:54
@wmertens
Copy link
Member

Please fix the formatting. I recommend you enable format-on-save in your editor, with Prettier support enabled.

@JerryWu1234
Copy link
Contributor Author

Please fix the formatting. I recommend you enable format-on-save in your editor, with Prettier support enabled.

thanks.I will
and let me fix it late

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit 5ed507e into QwikDev:build/v2 Jul 30, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants