Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 4 #6838

Closed
wants to merge 2 commits into from
Closed

Patch 4 #6838

wants to merge 2 commits into from

Conversation

hypecode-tech
Copy link
Contributor

@hypecode-tech hypecode-tech commented Aug 29, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Aug 29, 2024

⚠️ No Changeset found

Latest commit: b8a3d0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wmertens wmertens changed the base branch from add-showcase to main September 8, 2024 10:34
@wmertens wmertens requested a review from a team as a code owner September 8, 2024 10:34
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good and scoring >95, LGTM

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hypecode-tech you already added the website with this PR #6849
Am I missing something?

@gioboa
Copy link
Member

gioboa commented Sep 8, 2024

I close this one, your website is already there.

@gioboa gioboa closed this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants